add importpath_aliases to go_proto_library#2608
add importpath_aliases to go_proto_library#2608jayconrod merged 3 commits intobazel-contrib:masterfrom
Conversation
|
This PR seems incomplete? It doesn't actually implement |
|
@jayconrod in Line 19 of |
|
Im pretty new to rules_go but i think it works out of the box because |
jayconrod
left a comment
jayconrod
left a comment
There was a problem hiding this comment.
Oops, I'm sorry, you're totally right. I forgot how this worked and was thinking that adding this attribute would be a lot more complicated.
This PR looks good, just have two small comments. Thanks for fixing this.
|
np! @jayconrod responded to your comments! |
This reverts commit 631e26b. rules_go CI started failing after bazel-contrib#2608 was merged. For bazelbuild/bazel#11885
…ntrib#2712) The validating `py_test` generated by `compile_pip_requirements` chokes when the source `requirements.txt` is stored read-only, such as when managed by the Perforce Helix Core SCM. Though `dependency_resolver` makes a temporary copy of this file, it does so w/ `shutil.copy` which preserves the original read-only file mode. To address this, this commit replaces `shutil.copy` with a `shutil.copyfileobj` such that the temporary file is created w/ permissions according to the user's umask. Resolves (bazel-contrib#2608). --------- Co-authored-by: Ignas Anikevicius <240938+aignas@users.noreply.github.com>
3 participants
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
It allows go_proto_library to accept
importpath_aliasesas an argument. It is needed because gazelle generates go_proto_library rules that have importpath_aliases as an argument.Which issues(s) does this PR fix?
Fixes #2358